RFR: git-pr: use multi-command argument parser

Robin Westberg rwestberg at openjdk.java.net
Thu Feb 20 08:35:04 UTC 2020

On Thu, 20 Feb 2020 08:07:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this refactoring of `git pr` to start to use the
> `MultiCommandParser`. This refactoring is needed for several reasons:
> - not all subcommands support all options
> - better help messages
> - better reuse of utility functions
> - the code was essentially one gigantic `main` function
> I plan to split this file into multiple files, one for each command, but that is
> for a later refactoring. I have tried to preserve the semantics of all commands
> and have tested them locally.
> Thanks,
> Erik

Looks good to me!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/458

More information about the skara-dev mailing list