RFR: forge: add method diffUrl to PullRequest

Robin Westberg rwestberg at openjdk.java.net
Thu Feb 20 10:25:01 UTC 2020

On Thu, 20 Feb 2020 10:14:33 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that adds the method `PullRequest::diffUrl`.
> Although the implementation is the same for both `GitHubPullRequest` and
> `GitLabMergeRequest` I chose to not do a `default` method to highlight that this
> is more of a coincidence than a rule.
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/459

More information about the skara-dev mailing list