RFR: git-pr: publish later and polish error messages
Robin Westberg
rwestberg at openjdk.java.net
Fri Feb 21 11:58:22 UTC 2020
On Fri, 21 Feb 2020 11:25:22 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that ensure that `git pr create` runs `git publish` as
> _late_ as possible. This is to avoid GitHub showing the "You just pushed a
> branch" notification while the user is writing the pull request message in the
> editor.
>
> I also polished several of the error messages to provide better info and do
> better checks.
>
> Testing:
> - manual testing of `git pr create` on Linux x64
>
> Thanks,
> Erik
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/463
More information about the skara-dev
mailing list