RFR: git-jcheck: set exit code correctly

Robin Westberg rwestberg at openjdk.java.net
Fri Feb 21 13:17:31 UTC 2020

On Fri, 21 Feb 2020 13:08:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that ensures that `JCheckCLIVisitor` correctly
> sets `hasDisplayedError` for all errors. This will in turn make sure that
> `git-jcheck` exits with code `1` whenever an error has been shown which in
> turn will make `git create --jcheck` work correctly.
> Testing:
> - Manual testing of `git jcheck` and `git pr create --jcheck` on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/464

More information about the skara-dev mailing list