RFR: git-jcheck: add pre-push support

Robin Westberg rwestberg at openjdk.java.net
Mon Feb 24 14:29:44 UTC 2020

On Mon, 24 Feb 2020 14:21:09 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds support for the `--pre-push` and
> `--setup-pre-push-hook` to `git-jcheck`. Setting up a pre-push hook can
> beneficial for OpenJDK projects where contributors push directly (where they
> don't use `git-pr` and pull requests).
> Testing:
> - Manual testing on Linux x64
> Thanks,
> Erik

Looks good, just be consistent with the dash. :)

cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 119:

> 118:                   .fullname("setup-pre-push-hook")
> 119:                   .helptext("Set up a pre push hook that runs jcheck")
> 120:                   .optional(),


                  .helptext("Set up a pre-push hook that runs jcheck")


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/470

More information about the skara-dev mailing list