RFR: git-jcheck: add support for multiple pre-push hooks

Robin Westberg rwestberg at openjdk.java.net
Wed Feb 26 07:06:32 UTC 2020

On Tue, 25 Feb 2020 14:55:23 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds support for multiple kinds of pre-push hooks
> to `git-jcheck`. A user can now set up either the "branches" pre-push hook
> and/or the "commits" pre-push hook via `git jcheck
> --setup-pre-push-hooks=commits,branches`. The "commits" pre-push hook will run
> all commits about to pushed throught `git-jcheck`. The "branches"
> pre-push hook will check that you are not pushing to a branch in your personal
> fork that is also present in the upstream repository (rarely a good idea).
> Testing:
> - Manual testing of pre-push hooks and `git-jcheck` on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/474

More information about the skara-dev mailing list