RFR: 215: Verify webrev links before considering publication successful

[Erik Helin]

On Wed, 8 Jan 2020 09:12:27 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change which ensures that webrev links can be successfully reached before returning from the publication step. 
> 
> Best regards,
> Robin

Looks good, just a small suggestion on narrowing the range of successful HTTP status codes ��

bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java line 162:

> 161:                 var response = client.send(request, HttpResponse.BodyHandlers.ofString());
> 162:                 if (response.statusCode() < 400) {
> 163:                     // Success!

Suggestion:

                if (respons.statusCode() >= 200 && response.statusCode() < 400) {

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/345