[Rev 01] RFR: 222: Implement backport issue creation

[Erik Helin]

On Mon, 13 Jan 2020 08:05:56 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this initial implementation of updating the fixVersion of issues (possibly creating a backport issue) when they are resolved by a commit, following the existing rules of the current hg updater.
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

Very nice work Robin �� Just a few minor comments and suggestions.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 133:

> 132:     /**
> 133:      * Return True if fixVersionList is empty or contains only scratch values.
> 134:      */

Suggestion:

     * Return true if fixVersionList is empty or contains only scratch values.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 113:

> 112:     /**
> 113:      * Return True if the issue's fixVersionList is a match for fixVersion, using "-pool" or "-open".
> 114:      *

Suggestion:

     * Return true if the issue's fixVersionList is a match for fixVersion, using "-pool" or "-open".

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 157:

> 156:     /**
> 157:      * Return issue or one of its backports that applies to fixver.
> 158:      *

Suggestion:

     * Return issue or one of its backports that applies to fixVersion.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 162:

> 161:      * If the main issue       has a matching <N>-pool fixVersion, use it.
> 162:      * If an existing Backport has a matching <N>-pool fixVersion, use it.
> 163:      * If the main issue       has a "scratch" fixVersion, use it.

Perhaps add:

        * If the main issue       has a matching <N>-open fixVersion, use it.
        * If an existing Backport has a matching <N>-open fixVersion, use it.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 267:

> 266:                     if (requestedVersion != null) {
> 267:                         for (var oldVersion : issue.fixVersions()) {
> 268:                             issue.removeFixVersion(oldVersion);

Perhaps add a comment that the old fix versions can only "scratch" versions?

-------------



PR: https://git.openjdk.java.net/skara/pull/346