[Rev 01] RFR: 234: Allow more granular jcheck reviewer configuration

Erik Helin ehelin at openjdk.java.net
Mon Jan 20 15:38:10 UTC 2020


> Hi all,
> 
> please review this patch that allows for more granular reviewers configuration
> with jcheck. With this patch a project can now specify exactly how many
> reviewers are need for each role, for example:
> 
> [checks "reviewer"]
> reviewer = 1
> committer = 1
> author = 1
> 
> The above configuration would require three reviewers in total, out of which one
> must be reviewer, one must be committer and one must be author. This granularity
> of configuration is needed to fully implement [PR 364](https://git.openjdk.java.net/skara/pulls/364).
> 
> I made sure that the patch is backwards compatible, we still support the old
> configuration syntax:
> 
> [checks "reviewer"]
> minimum = 1
> role = reviewer
> 
> The above will simply be translated to the following configuration:
> 
> [checks "reviewer"]
> reviewer = 1
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Added a number of additional unit tests

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - c4d582cf: Fix spelling of method name

Changes:
  - all: https://git.openjdk.java.net/skara/pull/368/files
  - new: https://git.openjdk.java.net/skara/pull/368/files/7ce157a2..c4d582cf

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/368/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/368/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/368.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/368/head:pull/368

PR: https://git.openjdk.java.net/skara/pull/368


More information about the skara-dev mailing list