RFR: 235: git-webrev can't handle empty files

Robin Westberg rwestberg at openjdk.java.net
Tue Jan 21 07:24:24 UTC 2020

On Tue, 21 Jan 2020 07:20:46 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that makes `git-webrev` work with empty files (either
> added or removed). The addition or removal of an empty file can't unfortunately
> be represented using the unified diff output format (one needs "extended
> headers" like `git`), but we can still make the HTML view work.
> Thanks,
> Erik
> ## Testing
> - [x] Manual testing of `git-webrev` on repositories with empty files

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/369

More information about the skara-dev mailing list