[Rev 02] RFR: 217: Enforce check on number of required reviewers

Nir Lisker nlisker at openjdk.java.net
Wed Jan 22 20:46:46 UTC 2020

On Wed, 22 Jan 2020 13:12:25 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Thanks for making the requested update. To check that it matches my understanding, if the default policy as set in `.jcheck/conf` is 1 reviewer with a role of `Reviewer`, then I expect the following:
>> `/reviewers 0` -- error
>> `/reviewers 1` -- reset to default (1 reviewer with role of `Reviewer` in this example)
>> `/reviewers 2` -- num reviewers is now two, one of which must have the role of `Reviewer` and the other must have the role of `Author` (or higher)
>> Is my understanding correct? It seems so in looking at your most recent change, but wanted to double-check.
> Yep, that's correct!

Looks good. After this is integrated, when will it take effect? Reviewers need to be notified.


PR: https://git.openjdk.java.net/skara/pull/364

More information about the skara-dev mailing list