RFR: 241: Gradle version plugin should allow a version.txt file

Robin Westberg rwestberg at openjdk.java.net
Thu Jan 23 07:41:37 UTC 2020

On Thu, 23 Jan 2020 07:36:27 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that makes the `VersionPlugin` look for a
> `version.txt` in the root directory of the repository _if_ the `.git` directory
> is missing. This is useful to be able to build Skara with a proper version from
> e.g. a source tarball.
> Thanks,
> Erik
> ## Testing
> - [x] Manual testing in directory without `.git` present
> - [x] Manual testing in directory with `.git` present

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/375

More information about the skara-dev mailing list