RFR: Make it possible to only allow PRs against a select set of target branches

Erik Helin ehelin at openjdk.java.net
Fri Jan 24 07:02:07 UTC 2020

On Thu, 23 Jan 2020 13:21:16 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> Please review this change that makes it possible to only allow PRs to target a select set of branches.
> Best regards,
> Robin

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 74:

> 73:     private boolean checkTargetBranch() {
> 74:         var matcher = workItem.bot.allowedTargetBranches().matcher(pr.targetRef());
> 75:         return matcher.matches();

Should we use a pattern or should we simply just enumerate the protected branches? It seems potentially overkill to support a regex, it seems like an anti-pattern to have a repository with so many protected branches that they are cumbersome to enumerate, so you need a regex ��


PR: https://git.openjdk.java.net/skara/pull/377

More information about the skara-dev mailing list