RFR: 245: CLI tools do not consider git's http.proxy configuration

Robin Westberg rwestberg at openjdk.java.net
Fri Jan 24 08:01:56 UTC 2020

On Fri, 24 Jan 2020 07:49:10 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that makes the CLI tools respect git's
> [http.proxy](https://git-scm.com/docs/git-config#Documentation/git-config.txt-httpproxy)
> setting. The behavior with this patch is if `http_proxy`, `https_proxy` and/or
> `no_proxy` is *not* set, then we try to set the proxy based on git's
> `http.proxy` config (i.e. `http_proxy` and friends have precedence).
> Thanks,
> Erik
> ## Testing
> - [x] Manual testing of CLI tools behind http(s) proxy

Should the precedence order perhaps be changed to match how git treats the configuration?


PR: https://git.openjdk.java.net/skara/pull/379

More information about the skara-dev mailing list