[Rev 01] RFR: 245: CLI tools do not consider git's http.proxy configuration

Erik Helin ehelin at openjdk.java.net
Fri Jan 24 09:48:09 UTC 2020

> Hi all,
> please review this patch that makes the CLI tools respect git's
> [http.proxy](https://git-scm.com/docs/git-config#Documentation/git-config.txt-httpproxy)
> setting. The behavior with this patch is if `http_proxy`, `https_proxy` and/or
> `no_proxy` is *not* set, then we try to set the proxy based on git's
> `http.proxy` config (i.e. `http_proxy` and friends have precedence).
> Thanks,
> Erik
> ## Testing
> - [x] Manual testing of CLI tools behind http(s) proxy

The pull request has been updated with 1 additional commit.


Added commits:
 - a9b037ec: Let git's config value have precedence over env variables

  - all: https://git.openjdk.java.net/skara/pull/379/files
  - new: https://git.openjdk.java.net/skara/pull/379/files/8ba31022..a9b037ec

 - full: https://webrevs.openjdk.java.net/skara/379/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/379/webrev.00-01

  Stats: 58 lines in 1 file changed: 27 ins; 30 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/379.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/379/head:pull/379

PR: https://git.openjdk.java.net/skara/pull/379

More information about the skara-dev mailing list