[Rev 01] RFR: 245: CLI tools do not consider git's http.proxy configuration

Robin Westberg rwestberg at openjdk.java.net
Fri Jan 24 09:48:20 UTC 2020

On Fri, 24 Jan 2020 09:48:19 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that makes the CLI tools respect git's
>> [http.proxy](https://git-scm.com/docs/git-config#Documentation/git-config.txt-httpproxy)
>> setting. The behavior with this patch is if `http_proxy`, `https_proxy` and/or
>> `no_proxy` is *not* set, then we try to set the proxy based on git's
>> `http.proxy` config (i.e. `http_proxy` and friends have precedence).
>> Thanks,
>> Erik
>> ## Testing
>> - [x] Manual testing of CLI tools behind http(s) proxy
> The pull request has been updated with 1 additional commit.

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/379

More information about the skara-dev mailing list