[Rev 01] RFR: Make it possible to only allow PRs against a select set of target branches

Robin Westberg rwestberg at openjdk.java.net
Fri Jan 24 12:24:56 UTC 2020


On Fri, 24 Jan 2020 11:21:23 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 127:
> 
>> 126: 
>> 127:         if (!checkTargetBranch()) {
>> 128:             var error = "The branch `" + pr.targetRef() + "` is not allowed as target branch. The allowed target branches are:\n" +
> 
> Suggestion:
> 
>         if (!isTargetBranchAllowed()) {

Sounds good, will change!

-------------

PR: https://git.openjdk.java.net/skara/pull/377


More information about the skara-dev mailing list