RFR: 247: Support atomic pushes in with /integrate command
Erik Helin
ehelin at openjdk.java.net
Tue Jan 28 11:35:36 UTC 2020
On Tue, 28 Jan 2020 11:08:45 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> Hi all,
>
> Please review this change that allows pushing without automatic rebasing.
>
> Best regards,
> Robin
Looks good, just a minor nit on wording
bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 125:
> 124: if (!args.isBlank()) {
> 125: reply.println("Note that your sponsor will make the final decision on which target hash to integrate on.");
> 126: }
Suggestion:
reply.println("Note that your sponsor will make the final decision on which target hash to integrate upon.");
-------------
Marked as reviewed by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/384
More information about the skara-dev
mailing list