[Rev 02] RFR: 218: Enforce check on approval of CSRs

Erik Helin ehelin at openjdk.java.net
Wed Jan 29 08:36:46 UTC 2020


> Hi all,
> 
> please review this patch that adds a CSR bot. The CSR bot allows a reviewer to
> issue the command `/csr` in a pull request comment. Once issued, the PR cannot
> be integrated until the CSR for the issue associated with the PR is in state
> "Closed" and "Approved". A reviewer can cancel this requirement by issuing the
> command `/csr unneeded` in a pull request comment.
> 
> Testing:
> - Added a bunch of new unit tests for the `/csr` command and the CSR bot
> - `sh gradlew test` passes on Linux x64
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 800212db: Remove spurious printing

Changes:
  - all: https://git.openjdk.java.net/skara/pull/385/files
  - new: https://git.openjdk.java.net/skara/pull/385/files/c68a467f..800212db

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/385/webrev.02
 - incr: https://webrevs.openjdk.java.net/skara/385/webrev.01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/385.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/385/head:pull/385

PR: https://git.openjdk.java.net/skara/pull/385


More information about the skara-dev mailing list