RFR: 247: Support atomic pushes in with /integrate command

[Robin Westberg]

Hi Jon,

> On 29 Jan 2020, at 21:05, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> 
> On 1/28/20 5:33 AM, Erik Helin wrote:
>> On Tue, 28 Jan 2020 12:56:15 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> 
>>>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 125:
>>>> 
>>>>> 124:                     if (!args.isBlank()) {
>>>>> 125:                         reply.println("Note that your sponsor will make the final decision on which target hash to integrate on.");
>>>>> 126:                     }
>>>> Suggestion:
>>>> 
>>>>                         reply.println("Note that your sponsor will make the final decision on which target hash to integrate upon.");
>>> How about onto, as in `git rebase --onto`?
>> ��
>> 
>> -------------
>> 
>> PR: https://git.openjdk.java.net/skara/pull/384
> 
> 
> Some say you should not end a sentence with a preposition, and you've certainly got a double "on".
> 
> Suggestion:
> 
>                        reply.println("Note that your sponsor will make the final decision onto which target hash to integrate.”);

Thanks! I’ll create a follow-up PR to incorporate your suggestion.

Best regards,
Robin

> 
> -- Jon
> 
>