RFR: 438: Add "git pr issue" subcommand

[Robin Westberg]

On Wed, 1 Jul 2020 12:59:35 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `git pr issue` subcommand (corresponding
> to the `/issue` pull request command). A user can now run e.g. `git pr issue
> --add=SKARA-419` instead of the pull request command `/issue add SKARA-419`.
> 
> Testing:
> - [x] Manual testing of Linux x64
> 
> Thanks,
> Erik

Looks good, just one thing that probably should be changed. :)

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIssue.java line 96:

> 95:             var issueId = arguments.get("add").asString();
> 96:             var comment = pr.addComment("/issue add" + " " + issueId);
> 97:             showReply(awaitReplyTo(pr, comment));

Suggestion:

            var comment = pr.addComment("/issue remove" + " " + issueId);

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIssue.java line 95:

> 94:         } else if (arguments.contains("remove")) {
> 95:             var issueId = arguments.get("add").asString();
> 96:             var comment = pr.addComment("/issue add" + " " + issueId);

Suggestion:

            var issueId = arguments.get("remove").asString();

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/684