RFR: 443: /reviewer pull request command should accept multiple reviewers

Robin Westberg rwestberg at openjdk.java.net
Thu Jul 2 13:20:29 UTC 2020


On Thu, 2 Jul 2020 13:11:07 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes the `/reviewer` pull request command accept multiple reviewers at once.
> 
> Testing:
> - [x] Added a unit test
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good, just one question!

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewerCommand.java line 87:

> 86:         var reviewers = new ArrayList<Contributor>();
> 87:         for (var entry : matcher.group(2).split(" ")) {
> 88:             var reviewer = parseUser(entry, pr, censusInstance);

Should we allow "," as a separator as well, like the `/issue` and `/cc` commands?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/687


More information about the skara-dev mailing list