RFR: git-pr: add csr sub-command [v3]

Erik Helin ehelin at openjdk.java.net
Thu Jul 9 15:16:32 UTC 2020


On Thu, 9 Jul 2020 13:47:58 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java line 37:
>> 
>>> 36:     private static void showHelp(PrintWriter writer) {
>>> 37:         writer.println("usage: `/csr [needed|unneeded]`, requires that the issue the pull request links to an
>>> approved [CSR](https://wiki.openjdk.java.net/display/csr/Main) request."); 38:     }
>> 
>> Looks like a pre-existing typo:
>> Suggestion:
>> 
>>         writer.println("usage: `/csr [needed|unneeded]`, requires that the issue the pull request links to, links to an
>>         approved [CSR](https://wiki.openjdk.java.net/display/csr/Main) request.");
>
> Assuming the requirement is PR -(links to)-> Issue -(links to)-> CSR

Thanks for noticing this, I changed the usage message in a970e4ce2027a8f35d7e9dfffdc072e7c472b369. I used "... the
issue the pull request refers to links to an approve" in order to not get to consecutive "links to" �� What do you
think?

-------------

PR: https://git.openjdk.java.net/skara/pull/702


More information about the skara-dev mailing list