RFR: git-pr: add csr sub-command [v3]
Erik Helin
ehelin at openjdk.java.net
Thu Jul 9 15:16:33 UTC 2020
On Thu, 9 Jul 2020 13:45:42 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve help message
>
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java line 253:
>
>> 252: assertLastCommentContains(pr, "usage: `/csr [needed|unneeded]`, requires that the issue the pull
>> request links " + 253: "to an approved
>> [CSR](https://wiki.openjdk.java.net/display/csr/Main) request."); 254:
>> assertFalse(pr.labels().contains("csr"));
>
> Same here
> Suggestion:
>
> assertLastCommentContains(pr, "usage: `/csr [needed|unneeded]`, requires that the issue the pull request links " +
> "to, links to an approved [CSR](https://wiki.openjdk.java.net/display/csr/Main) request.");
Thanks, see my other reply above ☝
-------------
PR: https://git.openjdk.java.net/skara/pull/702
More information about the skara-dev
mailing list