RFR: SKARA-461: Do a git version check
Robin Westberg
rwestberg at openjdk.java.net
Thu Jul 30 08:22:01 UTC 2020
On Wed, 29 Jul 2020 11:38:27 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Hi,
>
> This PR adds a git version check to the `git skara` CLI. This will print a warning if the git version is not a known
> working version. Since outdated versions can lead to IOExceptions due to e.g. unsupported git CLI options, hopefully
> the warning message will help to inform users about their use of an unsupported git version, and a potential way to
> solve the problem i.e. upgrading to a more recent version. Currently at least git 2.22 is required since we use the
> `--combined-all-paths` option of git log (see GitCommits), which was added in 2.22. Thanks,
> Jorn
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/707
More information about the skara-dev
mailing list