RFR: webrev: proper index.html fix and charset fixes
Robin Westberg
rwestberg at openjdk.java.net
Wed Jun 3 12:44:56 UTC 2020
On Wed, 3 Jun 2020 12:35:36 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that fixes two issues in webrev:
>
> 1. Use a more robust band-aid for the problem when generating a webrev for a file named `index.html`
> 2. Try multiple charsets when reading files from disk
>
> Testing:
> - Manual testing of `git webrev` on Linux x64
> - `make test` passes on Linux x64
>
> Thanks,
> Erik
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/637
More information about the skara-dev
mailing list