FYI: publish: only exit on error

Robin Westberg rwestberg at openjdk.java.net
Thu Jun 11 10:38:15 UTC 2020


On Thu, 11 Jun 2020 10:29:58 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that ensures that `GitPublish.main` only calls `System.exit` on error. This is needed
> because `GitPrCreate.main` calls `GitPublish.main`, so `GitPublish.main` cannot unconditionally call `System.exit`.
> Testing:
> - [x] Manual testing of `git publish`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/655


More information about the skara-dev mailing list