RFR: 411: Warn when a PR issue is not of a primary type

Robin Westberg rwestberg at openjdk.java.net
Tue Jun 16 12:16:04 UTC 2020


On Tue, 16 Jun 2020 09:29:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a
> repository.
> Testing:
> - [x] Added a new unit test
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good, just had one minor comment / question.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 122:

> 121:             if (repo.value().contains("issuetypes")) {
> 122:                 var types = repo.value().get("issuetypes").asArray()
> 123:                                                           .stream()

You just do .stream directly here, right? At least I tend to do that.. :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/665


More information about the skara-dev mailing list