RFR: jcheck: always reload configuration

Robin Westberg rwestberg at openjdk.java.net
Wed Mar 4 15:05:55 UTC 2020

On Wed, 4 Mar 2020 14:59:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this pull request that always reloads the .jcheck/conf from the
> tree corresponding to a commit when checking said commit. The existing
> optimization may not work that well with merged histories where there are two
> branches with differing .jcheck/conf files. The performance impact from this
> patch is barely noticeable, so I suggest we opt for a safer and simpler
> implementation.
> Testing:
> - `make test` passes on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/492

More information about the skara-dev mailing list