[Rev 01] RFR: 276: Merge style PRs should generate "merge" webrevs
Erik Helin
ehelin at openjdk.java.net
Wed Mar 18 10:03:49 UTC 2020
On Tue, 17 Mar 2020 14:44:48 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this change that for merge style PRs generate webrevs only containing the changes done in the merge
>> commit.
>> Note that this is only a partial implementation, such webrevs should also be generated if there are further commits
>> pushed to the PR.
>> Best regards,
>> Robin
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>
> Generate actual merge-only webrevs
Looks good!
bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java line 50:
> 49: }
> 50: return mergeCommit;
> 51: } catch (IOException e) {
Suggestion:
return localRepo.lookup(head).filter(c -> c.isMerge());
-------------
Marked as reviewed by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/501
More information about the skara-dev
mailing list