RFR: 316: git-webrev does not work without origin remote

Robin Westberg rwestberg at openjdk.java.net
Thu Mar 19 05:27:48 UTC 2020

On Wed, 18 Mar 2020 15:21:59 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that updates `git-webrev` to work with repositories
> with slightly more unusual configurations by default. `git-webrev` will now by
> default work with many more repositories that for example have multiple remotes,
> repositories missing a remote named "origin", etc. For the most complicated
> scenarios the user can now also specify `--remote` to pick the remote that
> should be used for calculating outgoing changes.
> Testing:
> - Manual testing of `git-webrev` on Linux x64 with some more exotic repository
>   configurations
> Thanks,
> Erik

Looks good, just one question.

cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 166:

> 165:         var cwd = Paths.get("").toAbsolutePath();
> 166:         var repository = Repository.get(cwd);
> 167:         if (!repository.isPresent()) {

What non-read-only method did you need? Can't spot it. :)


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/517

More information about the skara-dev mailing list