RFR: jcheck: add symlink check
Robin Westberg
rwestberg at openjdk.java.net
Mon Mar 23 06:03:54 UTC 2020
On Mon, 23 Mar 2020 05:55:52 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that adds a check for symbolic links to JCheck.
>
> Testing:
> - `make test` passes on Linux x64
> - Added two new unit tests
>
> Thanks,
> Erik
Looks good, just a spelling comment!
bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 211:
> 210: public void visit(SymlinkIssue issue) {
> 211: messages.add(String.format("Symbolic linkes are not allowed (file: %s)", issue.path()));
> 212: failedChecks.add(issue.check().getClass());
Suggestion:
messages.add(String.format("Symbolic links are not allowed (file: %s)", issue.path()));
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/525
More information about the skara-dev
mailing list