RFR: cli: better handling of git-jcheck --lax

Robin Westberg rwestberg at openjdk.java.net
Mon Mar 23 08:09:22 UTC 2020

On Mon, 23 Mar 2020 08:01:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this PR that handles "lax" for JCheck much better, both when it
> comes to CLI reporting and for configuration parsing. Running `git jcheck --lax`
> will now hide a number of issues. The "legacy" JCheck parser now also
> understands the `comments = lax` configuration property.
> Testing:
> - `make test` passes on Linux x64
> - Manual testing of `git jcheck --lax`
> Thanks,
> Erik

Looks good to me!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/530

More information about the skara-dev mailing list