[Rev 02] RFR: jcheck: duplicate-issues should only check id and support "dup"

Robin Westberg rwestberg at openjdk.java.net
Mon Mar 23 12:27:34 UTC 2020


On Mon, 23 Mar 2020 12:22:26 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that makes the "duplicate-issues" check in JCheck
>> _only_ consider issue ids (e.g. `8123456`) when looking for duplicates. I also
>> added support for the "legacy" .jcheck/conf parser to understands the `bugids =
>> dup` configuration line.
>> 
>> Testing:
>> - Manual testing on Linux x64
>> 
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Do not rely on iteration order

Still looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/533


More information about the skara-dev mailing list