git webrev is extremely silent

Magnus Ihse Bursie magnus.ihse.bursie at
Tue Mar 24 12:51:36 UTC 2020

On 2020-03-24 13:42, Jaikiran Pai wrote:
> Any thoughts?
I agree, we need not follow the user-unfriendly unix-style of "no output 
means success". Perhaps just a confirmation message like "Webrev 
generated in <dir>" would be nice.

> -Jaikiran
> On 19/03/20 8:26 am, Jaikiran Pai wrote:
>> I have just started using the skara CLI tools to generate patches for
>> the jdk repositories. I am used to using the (original) webrev. When
>> using the original webrev, you see a bunch of "activity" that gets
>> logged on the screen and it finally writes out the patch where the
>> webrev changeset is generated.
>> However, when I run the "git webrev" command (sometimes with additional
>> options), it just silently returns. The first few times I tried it, I
>> thought it wasn't really working. It's only when I looked for directory
>> listing of potential places, where it might have generated the webrevs,
>> did I realize that the webrev was being generated successfully and it's
>> just that the git webrev command it way too silent and doesn't generate
>> any messages.
>> Adding a final summary, after the command executes successfully,
>> including the location where the webrev was generated would help, IMO.
>> Would this be considered a reasonable enhancement?
>> -Jaikiran

More information about the skara-dev mailing list