RFR: 343: Use `ssh -G` for parsing ssh configuration files

Robin Westberg rwestberg at openjdk.java.net
Tue Mar 31 07:24:39 UTC 2020

On Tue, 31 Mar 2020 07:17:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that uses `ssh -G` instead of relying on my (somewhat
> buggy) `ssh_config` parser. Resolving hosts defined in a `ssh_config` file is
> actually fairly complex and my parser only handled a subset of scenarios. One
> drawback is that we now rely on `ssh` being present on `PATH`, but that must be
> the case if a user has a SSH path for a remote.
> Testing:
> - Manual testing using `git-webrev` with various paths
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/553

More information about the skara-dev mailing list