[Rev 01] RFR: 344: PR should warn when source branch is an upstream branch

Robin Westberg rwestberg at openjdk.java.net
Tue Mar 31 14:44:47 UTC 2020


On Tue, 31 Mar 2020 14:38:28 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that warns contributors that creates a poll request
>> from a branch that is already present in the upstream repository. This is rarely
>> what you want to do and therefore we should issue a warning.
>> 
>> Testing:
>> - `make test` passes on Linux x64
>> 
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make HostedBranch a class

Even better! :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/555


More information about the skara-dev mailing list