commits not associated with github user?

[Thomas Stüfe]

Okay, I tried this and as expected the mail address remains unverified in
Github since it is not a real mail address (or is it? At least I have no
idea how to access this mail box, if it exists). Did this still work for
you with the mail address left unverified?

Thanks, Thomas

On Sat, Oct 31, 2020 at 10:49 AM Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:

> Hi Anirvan,
>
> interesting idea, thank you!
>
> But the openjdk mail addresses are not valid. I hesitate to add an invalid
> mail address to my Github profile. I'd rather that the correct mail
> addresses be used by the Skara tools, those we are registered in the census
> with and which are used by the Github account. Especially since these fake
> addresses also add confusion to mailing list traffic.
>
> Thanks, Thomas
>
>
> On Sat, Oct 31, 2020 at 9:16 AM Anirvan Sarkar <powers.anirvan at gmail.com>
> wrote:
>
>> Hi Thomas,
>>
>> I had also observed the same behaviour.
>> Then I noticed that OpenJDK commits are committed with OpenJDK email
>> address [1].
>> So I added my OpenJDK email address to GitHub email settings [2] and
>> after some days when I checked again, I found my commit was linked to my
>> GitHub user [3].
>>
>> Can you add your OpenJDK email address in your GitHub settings and see if
>> it works for you?
>> If it works then we can ask the Skara team to add this step in the Wiki.
>>
>> [1]
>> https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a.patch
>> [2] https://github.com/settings/emails
>> [3]
>> https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a
>>
>> On Wed, 28 Oct 2020 at 19:40, Thomas Stüfe <thomas.stuefe at gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> a small question: I associated my OpenJDK user with my GitHub user as
>>> explained in [1]. But I still do not see my github user associated with
>>> commits in the OpenJDK, e.g. for
>>>
>>> https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe#diff-40f3361acaecc2d05896655fa532ab5b6cba2885cbcc5796cac4e81d010763ba
>>>
>>> It says my name, fully written, not clickable. Seems to be the case for
>>> many developers, but not all of them. For some, the commit is actually
>>> linked to the Github user.
>>>
>>> Did I miss some step somewhere when setting up my user?
>>>
>>> Thanks!
>>> Thomas
>>>
>>> [1]
>>> https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-GettingStarted
>>>
>>
>>
>> --
>> Anirvan
>>
>