RFR: Deprecate GitLab award emojis for flagging a PR as reviewed

Erik Helin ehelin at openjdk.java.net
Tue Nov 3 13:35:58 UTC 2020

On Tue, 3 Nov 2020 09:23:04 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Before disabling support for GitLab award emojis as review markers, we can start with posting a notification about the preferred way.

Looks good!

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 678:

> 676:             var body = added.getValue() + "\n" +
> 677:                     " ⚠️ Marking a PR as reviewed using the emoji buttons is deprecated and will not be supported in the near future. " +
> 678:                     "Please use the `Approve` button instead!\n\n" +

Not sure whether we need the exclamation mark or not, I leave that up to you ��


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/939

More information about the skara-dev mailing list