RFR: pr: add /backport commit command

[Robin Westberg]

On Thu, 5 Nov 2020 12:58:24 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `/backport` [commit command](https://wiki.openjdk.java.net/display/SKARA/Commit+Commands#CommitCommands-/backport).
> 
> Testing:
> - [x] Added four new unit tests
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good, only some minor comments!

bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 64:

> 62:         var username = command.user().username();
> 63:         if (censusInstance.contributor(command.user()).isEmpty()) {
> 64:             reply.println("@" + username + " only OpenJDK [contributor](https://openjdk.java.net/bylaws#contributor) can use the `/backport` command");

Perhaps "only an" or only .. contributors?

bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 64:

> 62:         var username = command.user().username();
> 63:         if (censusInstance.contributor(command.user()).isEmpty()) {
> 64:             reply.println("@" + username + " only OpenJDK [contributor](https://openjdk.java.net/bylaws#contributor) can use the `/backport` command");

The command handler will prefix the reply with `@command-issuer` so should not need to do that manually.

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/945