Integrated: forge: return commit comment from addCommitComment

Robin Westberg rwestberg at openjdk.java.net
Mon Nov 9 11:42:24 UTC 2020


On Mon, 9 Nov 2020 11:37:46 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `HostedRepository.addCommitComment` return the newly created commit comment. I had to make a workaround for GitLab's REST API since it doesn't return an id for commit comment. Instead we calculate an id based on the hash, the user's id an the time the comment was created.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/947


More information about the skara-dev mailing list