RFR: vcs: add DiffComparator for comparing diffs [v2]

Robin Westberg rwestberg at openjdk.java.net
Wed Nov 11 14:21:12 UTC 2020


On Wed, 11 Nov 2020 14:18:50 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds the new class `DiffComparator` in `vcs` for comparing `Diff`s. I've also updated `CheckRun` to make use of this new class.
>> 
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Looks obviously correct, but perhaps some test would be nice to have at some point. :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/951


More information about the skara-dev mailing list