RFR: SKARA-725: Rename git-pr-reviewer --add to git-pr-reviewer --credit

Erik Helin ehelin at openjdk.java.net
Thu Nov 12 11:04:29 UTC 2020

On Mon, 2 Nov 2020 17:24:38 GMT, Kartik Ohri <github.com+27751938+amCap1712 at openjdk.org> wrote:

> Hi!
> The patch renames the add option to the credit in accordance with the change in the `/reviewer` command on OpenJDK Github bot.
> I was unable to find any related documentation that should reflect  this change. If something needs to be updated, kindly point me to it and I'll do the needful changes.
> Thanks.
> Regards,
> Kartik

Looks good, just a small suggestion on the helptext for the option. I updated the documentation at https://wiki.openjdk.java.net/display/SKARA/reviewer.

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrReviewer.java line 37:

> 35:               .fullname("credit")
> 36:               .describe("USERNAME")
> 37:               .helptext("Consider pull request reviewed by this user")


              .helptext("Credit a person as a reviewer of this pull request")


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/938

More information about the skara-dev mailing list