RFR: jcheck: conditionally check backport reviewers

Robin Westberg rwestberg at openjdk.java.net
Wed Oct 14 15:01:10 UTC 2020


On Wed, 14 Oct 2020 14:30:11 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it possible to configure whether reviewers are required or not for backport
> commits. The `reviewers` check now supports the configuration `backports=check` or `backports=ignore` with
> `backports=ignore` being the default. We will still check for invalid reviewers and self-reviews, it is just the
> "number of reviewers" that can be disabled for backport commits.  Testing:
> - [x] Added three new unit tests
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/884


More information about the skara-dev mailing list