RFR: pr: detect clean backports [v2]

Robin Westberg rwestberg at openjdk.java.net
Fri Oct 16 10:02:25 UTC 2020

On Fri, 16 Oct 2020 09:59:58 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport
>> pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines
>> being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the
>> changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a
>> fuzzing factor via `--fuzz` that is the same as the number of context lines.  A clean backport also doesn't require
>> reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch.
>> Testing:
>> - [x] Added a bunch of tests
>> - [x] `make test` passes on Linux x64
>> Thanks,
>> Erik
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>   Fix spelling
>   Co-authored-by: Robin Westberg <robin at westberg.se>

Looks good!

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 962:

> 960:             try {
> 961:                 // Do not pass eventual original commit even for backports since it will cause
> 962:                 // the reviwer check to be ignored.


                // the reviewer check to be ignored.


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/885

More information about the skara-dev mailing list