RFR: forge: add HostedRepository.recentCommitComments [v3]
Erik Helin
ehelin at openjdk.java.net
Mon Oct 19 14:58:45 UTC 2020
> Hi all,
>
> please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit
> comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are
> very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it
> doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make
> `CommitComment` support lazily fetching the hash for the commit. Thanks, Erik
Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since
the last revision:
- Merge master
- forge: add HostedRepository.recentCommitComments
- forge: add builder for HostUser
-------------
Changes:
- all: https://git.openjdk.java.net/skara/pull/891/files
- new: https://git.openjdk.java.net/skara/pull/891/files/d5a7d603..5e04fea7
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=02
- incr: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=01-02
Stats: 199 lines in 3 files changed: 0 ins; 198 del; 1 mod
Patch: https://git.openjdk.java.net/skara/pull/891.diff
Fetch: git fetch https://git.openjdk.java.net/skara pull/891/head:pull/891
PR: https://git.openjdk.java.net/skara/pull/891
More information about the skara-dev
mailing list