RFR: vcs: fix hunk line parsing in UnifiedDiffParser

Robin Westberg rwestberg at openjdk.java.net
Wed Oct 21 10:11:42 UTC 2020

On Wed, 21 Oct 2020 10:07:06 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that fixes the parsing in `UnifiedDiffParser.parseSingleFileDiff` a bit. The parser now understands Git's extended headers and also properly moves past a hunk start lines (lines starting with `@@`).
> Testing:
> - [x] Added a new unit test
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/897

More information about the skara-dev mailing list