RFR: forge: fix GitLabRepository.recentCommitComments

Robin Westberg rwestberg at openjdk.java.net
Fri Oct 23 09:10:11 UTC 2020


On Fri, 23 Oct 2020 08:33:59 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that fixes `recentCommitsComments` for `GitLabRepository`. The formatting of the `after` parameter was wrong (used day of year instead of day of month) and the `id` was using `String` instead of `int` as type.
> 
> Thanks,
> Erik
> 
> - Fix formatting of "after"
> - Fix type of "id"

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/912


More information about the skara-dev mailing list