Integrated: Fix skara update on Windows when CWD is not skara repository dir
Christoph Langer
clanger at openjdk.java.net
Mon Oct 26 07:52:24 UTC 2020
On Fri, 23 Oct 2020 21:25:39 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> On my windows client, I'm running in an issue when updating the skara tools. I see the following output/exception:
>
> Checking for updates ...
> Found the following updates:
> - forge: patch for commit can be null
> Rebuilding ...
> Exception in thread "main" java.io.IOException: Cannot run program "gradlew.bat" (in directory "C:\git\OpenJDK\skara"): CreateProcess error=2, The system cannot find the file specified
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128)
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071)
> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.update(GitSkara.java:176)
> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:230)
> Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified
> at java.base/java.lang.ProcessImpl.create(Native Method)
> at java.base/java.lang.ProcessImpl.<init>(ProcessImpl.java:483)
> at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:158)
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1107)
> ... 3 more
>
> The issue seems to be that only "gradlew.bat" is added as command to the gradle call (https://github.com/openjdk/skara/blob/master/cli/src/main/java/org/openjdk/skara/cli/GitSkara.java#L168). The process directory is set to the skara repository directory. However, "gradlew.bat" isn't resolved against the working directory by Processbuilder, but probably only against the current %PATH%.
>
> Currently, when running "git skara update" out of the skara repository path, it'll work.
>
> With the proposed tiny fix to resolve gradlew.bat before starting the Processbuilder it can be run from any working directory.
This pull request has now been integrated.
Changeset: bd4cc7e9
Author: Christoph Langer <clanger at openjdk.org>
Committer: Robin Westberg <rwestberg at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/bd4cc7e9
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Fix skara update on Windows when CWD is not skara repository dir
Reviewed-by: ehelin
-------------
PR: https://git.openjdk.java.net/skara/pull/916
More information about the skara-dev
mailing list