RFR: vcs: handle binary files in UnifiedDiffParser

Robin Westberg rwestberg at openjdk.java.net
Thu Oct 29 17:50:30 UTC 2020


On Thu, 29 Oct 2020 15:32:18 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that handles binary files in the `UnifiedDiffParser`.
> 
> Testing:
> - [x] Added a unit test
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/930


More information about the skara-dev mailing list